-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: made timeAgo function way shorter and viewCount shorter #54583
fix: made timeAgo function way shorter and viewCount shorter #54583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think things look good.
Left some comments 👍
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md
Show resolved
Hide resolved
Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through again and found a couple of small things.
but otherwise good
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/64440a50d076c204051f2cc0.md
Show resolved
Hide resolved
Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes in the meta.json file on this PR. I think the challengeOrder needs to be changed to match all these changes.
Good catch Tom! Maybe the Usually though, when you run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! just minor optional suggestions.
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
...rn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/6443c98ac169e501eba36d04.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joy Shaheb <khondokoralam@gmail.com>
Yea I expected the meta.json file to be automatically updated. I'm on it now. |
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX
Check steps 22 and 23 for the
timeAgo
function, and step 25 for theviewCount
function.